From 9bdb7da98ce145432cada976b1252d269fdd9bc3 Mon Sep 17 00:00:00 2001 From: Sam Becker Date: Sat, 29 Mar 2025 23:40:01 -0500 Subject: [PATCH 1/2] Parameterize static camera paths --- app/shot-on/[make]/[model]/image/route.tsx | 2 +- app/shot-on/[make]/[model]/page.tsx | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/app/shot-on/[make]/[model]/image/route.tsx b/app/shot-on/[make]/[model]/image/route.tsx index 90d00979..658a8efb 100644 --- a/app/shot-on/[make]/[model]/image/route.tsx +++ b/app/shot-on/[make]/[model]/image/route.tsx @@ -15,7 +15,7 @@ export const generateStaticParams = staticallyGenerateCategoryIfConfigured( 'cameras', 'image', getUniqueCameras, - cameras => cameras.map(({ camera }) => camera), + cameras => cameras.map(({ camera }) => formatCameraParams(camera)), ); export async function GET( diff --git a/app/shot-on/[make]/[model]/page.tsx b/app/shot-on/[make]/[model]/page.tsx index b25a0553..cb597b0b 100644 --- a/app/shot-on/[make]/[model]/page.tsx +++ b/app/shot-on/[make]/[model]/page.tsx @@ -1,5 +1,5 @@ import { Metadata } from 'next/types'; -import { CameraProps } from '@/camera'; +import { CameraProps, formatCameraParams } from '@/camera'; import { generateMetaForCamera } from '@/camera/meta'; import { INFINITE_SCROLL_GRID_INITIAL } from '@/photo'; import { getPhotosCameraDataCached } from '@/camera/data'; @@ -21,7 +21,7 @@ export const generateStaticParams = staticallyGenerateCategoryIfConfigured( 'cameras', 'page', getUniqueCameras, - cameras => cameras.map(({ camera }) => camera), + cameras => cameras.map(({ camera }) => formatCameraParams(camera)), ); export async function generateMetadata({ From e5146081d477d6e9370615bff7758567297b3293 Mon Sep 17 00:00:00 2001 From: Sam Becker Date: Sat, 29 Mar 2025 23:47:43 -0500 Subject: [PATCH 2/2] Parameterize static lens paths --- src/lens/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/lens/index.ts b/src/lens/index.ts index 3242d424..21393026 100644 --- a/src/lens/index.ts +++ b/src/lens/index.ts @@ -51,8 +51,8 @@ export const safelyGenerateLensStaticParams = ( lenses: Lenses, ) => lenses.map(({ lens: { make, model } }) => ({ - make: make ?? MISSING_FIELD, - model, + make: make ? parameterize(make) : MISSING_FIELD, + model: parameterize(model), })); // Support keys for make-only and model-only lens queries