From 4cd29ed6861ef4803b7fb0a7a28fe30aec794ab3 Mon Sep 17 00:00:00 2001
From: Sam Becker <sam@sambecker.com>
Date: Mon, 10 Feb 2025 19:29:48 -0600
Subject: [PATCH] Simplify useImageZoomControls hook

---
 src/components/image/useImageZoomControls.ts | 49 ++++++++++----------
 1 file changed, 25 insertions(+), 24 deletions(-)

diff --git a/src/components/image/useImageZoomControls.ts b/src/components/image/useImageZoomControls.ts
index a3471672..6c192250 100644
--- a/src/components/image/useImageZoomControls.ts
+++ b/src/components/image/useImageZoomControls.ts
@@ -21,32 +21,27 @@ export default function useImageZoomControls(
 
   useMetaThemeColor({ colorLight });
 
-  const open = useCallback(() => {
-    viewerRef.current?.show();
-  }, [viewerRef]);
+  const open = useCallback(() =>
+    viewerRef.current?.show(), []);
 
-  const close = useCallback(() => {
-    viewerRef.current?.hide();
-  }, [viewerRef]);
+  const close = useCallback(() =>
+    viewerRef.current?.hide(), []);
 
-  const zoomTo = useCallback((zoomLevel = 1) => {
-    viewerRef.current?.zoomTo(zoomLevel);
-  }, [viewerRef]);
+  const zoomTo = useCallback((zoomLevel = 1) =>
+    viewerRef.current?.zoomTo(zoomLevel), []);
 
   const reset = useCallback(() => {
     setZoomLevel(1);
     viewerRef.current?.reset();
-  }, [viewerRef]);
+  }, []);
 
   // On 'F' keydown, toggle fullscreen
   const handleKeyDown = useCallback(() => {
-    if (shouldExpandOnFKeydown) {
-      viewerRef.current?.show();
-    }
-  }, [shouldExpandOnFKeydown]);
+    if (shouldExpandOnFKeydown) { open(); }
+  }, [shouldExpandOnFKeydown, open]);
   useKeydownHandler(handleKeyDown, ['F']);
 
-  useEffect(() => {
+  const initialize = useCallback(() => {
     if (imageRef.current && isEnabled) {
       viewerRef.current = new Viewer(imageRef.current, {
         navbar: false,
@@ -61,6 +56,7 @@ export default function useImageZoomControls(
             (target as any).viewer.viewer as HTMLDivElement;
         },
         url: (image: HTMLImageElement) => {
+          // Addresses Safari bug where images don't load
           image.loading = 'eager';
           return image.src;
         },
@@ -69,9 +65,8 @@ export default function useImageZoomControls(
           setColorLight('#000');
         },
         hide: () => {
-          setTimeout(() => {
-            setColorLight(undefined);
-          }, 300);
+          // Optimizes Safari status bar animation
+          setTimeout(() => setColorLight(undefined), 300);
         },
         hidden: () => {
           setShouldRespondToKeyboardCommands?.(true);
@@ -80,20 +75,26 @@ export default function useImageZoomControls(
           setZoomLevel(ratio);
         },
       });
-
-      return () => {
-        viewerRef.current?.destroy();
-        viewerRef.current = null;
-      };
     }
   }, [
     imageRef,
     isEnabled,
-    zoomTo,
     setShouldRespondToKeyboardCommands,
   ]);
 
+  const cleanUp = useCallback(() => {
+    viewerRef.current?.destroy();
+    viewerRef.current = null;
+  }, []);
+
+  useEffect(() => {
+    initialize();
+    return cleanUp;
+  }, [initialize, cleanUp]);
+
   return {
+    initialize,
+    cleanUp,
     open,
     close,
     reset,