From 99dde505b362a02ce9318d2ab9c8f34008144602 Mon Sep 17 00:00:00 2001
From: Sam Becker <sam@sambecker.com>
Date: Tue, 1 Apr 2025 21:15:55 -0500
Subject: [PATCH] Standardize recipe props

---
 .vscode/settings.json                      |  1 +
 app/admin/recipes/[recipe]/edit/page.tsx   |  2 +-
 src/admin/AdminShowRecipeButton.tsx        | 19 ++-------
 src/image-response/RecipeImageResponse.tsx |  2 +-
 src/photo/PhotoLarge.tsx                   |  2 +-
 src/recipe/PhotoRecipeOverlay.tsx          | 12 +++---
 src/recipe/RecipeHeader.tsx                |  2 +-
 src/recipe/index.ts                        | 46 +++++++++++-----------
 8 files changed, 36 insertions(+), 50 deletions(-)

diff --git a/.vscode/settings.json b/.vscode/settings.json
index ea94cecd..4a786c5d 100644
--- a/.vscode/settings.json
+++ b/.vscode/settings.json
@@ -8,6 +8,7 @@
     "Astia",
     "authjs",
     "camelcase",
+    "CLAR",
     "cloudflarestorage",
     "cmdk",
     "Consolas",
diff --git a/app/admin/recipes/[recipe]/edit/page.tsx b/app/admin/recipes/[recipe]/edit/page.tsx
index c9db0fbd..9565cc55 100644
--- a/app/admin/recipes/[recipe]/edit/page.tsx
+++ b/app/admin/recipes/[recipe]/edit/page.tsx
@@ -45,7 +45,7 @@ export default async function RecipePageEdit({
       accessory={recipeData && film &&
         <AdminShowRecipeButton
           title={recipe}
-          recipe={recipeData}
+          data={recipeData}
           film={film}
         />
       }
diff --git a/src/admin/AdminShowRecipeButton.tsx b/src/admin/AdminShowRecipeButton.tsx
index bfe97689..80fd1ca8 100644
--- a/src/admin/AdminShowRecipeButton.tsx
+++ b/src/admin/AdminShowRecipeButton.tsx
@@ -1,20 +1,11 @@
 'use client';
 
 import LoaderButton from '@/components/primitives/LoaderButton';
-import { FujifilmRecipe } from '@/platforms/fujifilm/recipe';
-import { FujifilmSimulation } from '@/platforms/fujifilm/simulation';
+import { RecipeProps } from '@/recipe';
 import { useAppState } from '@/state/AppState';
 import { TbChecklist } from 'react-icons/tb';
 
-export default function AdminShowRecipeButton({
-  title,
-  recipe,
-  film,
-}: {
-  title: string
-  recipe: FujifilmRecipe
-  film: FujifilmSimulation
-}) {
+export default function AdminShowRecipeButton(props: RecipeProps) {
   const { setRecipeModalProps } = useAppState();
 
   return (
@@ -23,11 +14,7 @@ export default function AdminShowRecipeButton({
         size={17}
         className="translate-y-[1px]"
       />}
-      onClick={() => setRecipeModalProps?.({
-        title,
-        recipe,
-        film,
-      })}
+      onClick={() => setRecipeModalProps?.(props)}
     >
         Preview
     </LoaderButton>
diff --git a/src/image-response/RecipeImageResponse.tsx b/src/image-response/RecipeImageResponse.tsx
index a2af4863..ba311a67 100644
--- a/src/image-response/RecipeImageResponse.tsx
+++ b/src/image-response/RecipeImageResponse.tsx
@@ -34,7 +34,7 @@ export default function RecipeImageResponse({
 
   let recipeLines = recipeData && film
     ? generateRecipeText({
-      recipe: recipeData,
+      data: recipeData,
       film,
     }, true)
     : [];
diff --git a/src/photo/PhotoLarge.tsx b/src/photo/PhotoLarge.tsx
index 61a5f9e3..74ca9b53 100644
--- a/src/photo/PhotoLarge.tsx
+++ b/src/photo/PhotoLarge.tsx
@@ -229,7 +229,7 @@ export default function PhotoLarge({
               <PhotoRecipeOverlay
                 ref={refRecipe}
                 title={photo.recipeTitle}
-                recipe={photo.recipeData}
+                data={photo.recipeData}
                 film={photo.film}
                 iso={photo.isoFormatted}
                 exposure={photo.exposureCompensationFormatted}
diff --git a/src/recipe/PhotoRecipeOverlay.tsx b/src/recipe/PhotoRecipeOverlay.tsx
index e3c02eb8..d5107273 100644
--- a/src/recipe/PhotoRecipeOverlay.tsx
+++ b/src/recipe/PhotoRecipeOverlay.tsx
@@ -24,7 +24,7 @@ import { labelForFilm } from '@/film';
 export default function PhotoRecipeOverlay({
   ref,
   title,
-  recipe,
+  data,
   film,
   onClose,
 }: RecipeProps & {
@@ -43,9 +43,9 @@ export default function PhotoRecipeOverlay({
     colorChromeFXBlue,
     bwAdjustment,
     bwMagentaGreen,
-  } = recipe;
+  } = data;
 
-  const whiteBalanceTypeFormatted = formatWhiteBalance(recipe);
+  const whiteBalanceTypeFormatted = formatWhiteBalance(data);
 
   const renderDataSquare = (
     value: ReactNode,
@@ -122,7 +122,7 @@ export default function PhotoRecipeOverlay({
           label={`${title
             ? `${formatRecipe(title).toLocaleUpperCase()} recipe`
             : 'Recipe'}`}
-          text={generateRecipeText({ title, recipe, film }).join('\n')}
+          text={generateRecipeText({ title, data, film }).join('\n')}
           iconSize={17}
           className={clsx(
             'translate-y-[0.5px]',
@@ -171,7 +171,7 @@ export default function PhotoRecipeOverlay({
           'col-span-8',
         )}
         {renderDataSquare(
-          formatNoiseReduction(recipe),
+          formatNoiseReduction(data),
           'ISO NR',
           'col-span-4',
         )}
@@ -195,7 +195,7 @@ export default function PhotoRecipeOverlay({
         )}
         {/* ROW */}
         {renderDataSquare(
-          formatGrain(recipe),
+          formatGrain(data),
           'grain',
           'col-span-6',
         )}
diff --git a/src/recipe/RecipeHeader.tsx b/src/recipe/RecipeHeader.tsx
index 0613238a..ebbb80e3 100644
--- a/src/recipe/RecipeHeader.tsx
+++ b/src/recipe/RecipeHeader.tsx
@@ -35,7 +35,7 @@ export default function RecipeHeader({
           photo?.film
         ) ? setRecipeModalProps?.({
             title: photo.recipeTitle,
-            recipe: photo.recipeData,
+            data: photo.recipeData,
             film: photo.film,
             iso: photo.isoFormatted,
             exposure: photo.exposureTimeFormatted,
diff --git a/src/recipe/index.ts b/src/recipe/index.ts
index 616e1849..d3735c92 100644
--- a/src/recipe/index.ts
+++ b/src/recipe/index.ts
@@ -18,7 +18,7 @@ export type Recipes = RecipeWithCount[]
 
 export interface RecipeProps {
   title?: string
-  recipe: FujifilmRecipe
+  data: FujifilmRecipe
   film: string
   iso?: string
   exposure?: string   
@@ -55,7 +55,7 @@ export const descriptionForRecipePhotos = (
 
 export const generateRecipeText = ({
   title,
-  recipe,
+  data,
   film,
 }: RecipeProps,
 abbreviate?: boolean,
@@ -63,53 +63,51 @@ abbreviate?: boolean,
   const lines = [
     `${labelForFilm(film).small.toLocaleUpperCase()}`,
     // eslint-disable-next-line max-len
-    `${formatWhiteBalance(recipe).toLocaleUpperCase()} ${formatWhiteBalanceColor(recipe)}`,
+    `${formatWhiteBalance(data).toLocaleUpperCase()} ${formatWhiteBalanceColor(data)}`,
   ];
 
   if (abbreviate) {
     // eslint-disable-next-line max-len
-    lines.push(`DR${recipe.dynamicRange.development} NR${formatNoiseReduction(recipe)}`);
+    lines.push(`DR${data.dynamicRange.development} NR${formatNoiseReduction(data)}`);
   } else {
     lines.push(
-      `DYNAMIC RANGE ${recipe.dynamicRange.development}`,
-      `NOISE REDUCTION ${formatNoiseReduction(recipe)}`,
+      `DYNAMIC RANGE ${data.dynamicRange.development}`,
+      `NOISE REDUCTION ${formatNoiseReduction(data)}`,
     );
   }
 
-  if (recipe.highlight || recipe.shadow) {
+  if (data.highlight || data.shadow) {
     lines.push(abbreviate
-      ? `HIGH${addSign(recipe.highlight)} SHAD${addSign(recipe.shadow)}`
-      // eslint-disable-next-line max-len
-      : `HIGHLIGHT ${addSign(recipe.highlight)} SHADOW ${addSign(recipe.shadow)}`,
+      ? `HIGH${addSign(data.highlight)} SHAD${addSign(data.shadow)}`
+      : `HIGHLIGHT ${addSign(data.highlight)} SHADOW ${addSign(data.shadow)}`,
     );
   }
   lines.push(abbreviate
     // eslint-disable-next-line max-len
-    ? `COL${addSign(recipe.color)} SHARP${addSign(recipe.sharpness)} CLAR${addSign(recipe.clarity)}`
+    ? `COL${addSign(data.color)} SHARP${addSign(data.sharpness)} CLAR${addSign(data.clarity)}`
     // eslint-disable-next-line max-len
-    : `COLOR ${addSign(recipe.color)} SHARPEN ${addSign(recipe.sharpness)} CLARITY ${addSign(recipe.clarity)}`,
+    : `COLOR ${addSign(data.color)} SHARPEN ${addSign(data.sharpness)} CLARITY ${addSign(data.clarity)}`,
   );
-  if (recipe.colorChromeEffect) {
+  if (data.colorChromeEffect) {
     lines.push(abbreviate
-      ? `CHROME ${recipe.colorChromeEffect.toLocaleUpperCase()}`
-      : `COLOR CHROME ${recipe.colorChromeEffect.toLocaleUpperCase()}`,
+      ? `CHROME ${data.colorChromeEffect.toLocaleUpperCase()}`
+      : `COLOR CHROME ${data.colorChromeEffect.toLocaleUpperCase()}`,
     );
   }
-  if (recipe.colorChromeFXBlue) {
+  if (data.colorChromeFXBlue) {
     lines.push(abbreviate
-      ? `FX BLUE ${recipe.colorChromeFXBlue.toLocaleUpperCase()}`
-      : `CHROME FX BLUE ${recipe.colorChromeFXBlue.toLocaleUpperCase()}`,
+      ? `FX BLUE ${data.colorChromeFXBlue.toLocaleUpperCase()}`
+      : `CHROME FX BLUE ${data.colorChromeFXBlue.toLocaleUpperCase()}`,
     );
   }
-  if (recipe.grainEffect.roughness !== 'off') {
-    lines.push(`GRAIN ${formatGrain(recipe, abbreviate)}`);
+  if (data.grainEffect.roughness !== 'off') {
+    lines.push(`GRAIN ${formatGrain(data, abbreviate)}`);
   }
-  if (recipe.bwAdjustment || recipe.bwMagentaGreen) {
+  if (data.bwAdjustment || data.bwMagentaGreen) {
     lines.push(abbreviate
+      ? `BW ADJ${addSign(data.bwAdjustment)} M/G${addSign(data.bwMagentaGreen)}`
       // eslint-disable-next-line max-len
-      ? `BW ADJ${addSign(recipe.bwAdjustment)} M/G${addSign(recipe.bwMagentaGreen)}`
-      // eslint-disable-next-line max-len
-      : `BW ADJUSTMENT ${addSign(recipe.bwAdjustment)} MAGENTA/GREEN ${addSign(recipe.bwMagentaGreen)}`,
+      : `BW ADJUSTMENT ${addSign(data.bwAdjustment)} MAGENTA/GREEN ${addSign(data.bwMagentaGreen)}`,
     );
   }