From a86f04b654e91b8b5e7129bf7bd133660ebc05fd Mon Sep 17 00:00:00 2001
From: Sam Becker <sam@sambecker.com>
Date: Thu, 10 Jul 2025 10:05:55 -0500
Subject: [PATCH] Enforce visibility types

---
 src/components/SelectMenuOption.tsx | 8 ++++----
 src/photo/visibility/index.tsx      | 2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/components/SelectMenuOption.tsx b/src/components/SelectMenuOption.tsx
index 4ae6869f..809aa3d2 100644
--- a/src/components/SelectMenuOption.tsx
+++ b/src/components/SelectMenuOption.tsx
@@ -2,15 +2,15 @@ import clsx from 'clsx/lite';
 import { ReactNode, useEffect, useRef } from 'react';
 import IconCheck from './icons/IconCheck';
 
-export interface SelectMenuOptionType {
-  value: string
+export type SelectMenuOptionType<T = string> = {
+  value: T
   label: ReactNode
   accessoryStart?: ReactNode
   accessoryEnd?: ReactNode
   note?: ReactNode
 }
 
-export default function SelectMenuOption({
+export default function SelectMenuOption<T = string>({
   label,
   accessoryStart,
   accessoryEnd,
@@ -24,7 +24,7 @@ export default function SelectMenuOption({
   isHighlighted?: boolean
   shouldHighlightOnHover?: boolean
   onClick?: () => void
-} & SelectMenuOptionType) {
+} & SelectMenuOptionType<T>) {
   const ref = useRef<HTMLDivElement>(null);
 
   useEffect(() => {
diff --git a/src/photo/visibility/index.tsx b/src/photo/visibility/index.tsx
index 88b72317..fde2294c 100644
--- a/src/photo/visibility/index.tsx
+++ b/src/photo/visibility/index.tsx
@@ -10,7 +10,7 @@ export const EXCLUDE_DESCRIPTION =
 export const PRIVATE_DESCRIPTION =
   'Visible only to admins';
 
-export const VISIBILITY_OPTIONS: SelectMenuOptionType[] = [
+export const VISIBILITY_OPTIONS: SelectMenuOptionType<VisibilityValue>[] = [
   {
     value: 'default',
     accessoryStart: <IconHidden size={17} visible />,