From b115b98ea5ecabce0fb2eda208406e59f09304ad Mon Sep 17 00:00:00 2001
From: Sam Becker <sam@sambecker.com>
Date: Wed, 18 Jun 2025 09:27:45 -0500
Subject: [PATCH] Change upload responsive buttons

---
 src/admin/AdminBatchUploadActions.tsx      | 4 ++--
 src/admin/AdminPhotosClient.tsx            | 2 +-
 src/admin/AdminPhotosSyncClient.tsx        | 2 +-
 src/admin/AdminUploadsTableRow.tsx         | 4 ++--
 src/admin/ClearCacheButton.tsx             | 2 +-
 src/admin/EditButton.tsx                   | 4 +---
 src/components/ImageInput.tsx              | 2 +-
 src/components/more/MoreMenuItem.tsx       | 2 +-
 src/components/primitives/LoaderButton.tsx | 7 ++++---
 9 files changed, 14 insertions(+), 15 deletions(-)

diff --git a/src/admin/AdminBatchUploadActions.tsx b/src/admin/AdminBatchUploadActions.tsx
index 38ff6221..76066fbe 100644
--- a/src/admin/AdminBatchUploadActions.tsx
+++ b/src/admin/AdminBatchUploadActions.tsx
@@ -218,7 +218,7 @@ export default function AdminBatchUploadActions({
                   }
                 }
               }}
-              hideTextOnMobile={false}
+              hideText="never"
             >
               {buttonText}
             </ProgressButton>
@@ -235,7 +235,7 @@ export default function AdminBatchUploadActions({
               }}
               className="w-full flex justify-center"
               shouldRedirectToAdminPhotos
-              hideTextOnMobile={false}
+              hideText="never"
               disabled={isAdding}
             >
               Delete All Uploads
diff --git a/src/admin/AdminPhotosClient.tsx b/src/admin/AdminPhotosClient.tsx
index 39a381b5..602a02b2 100644
--- a/src/admin/AdminPhotosClient.tsx
+++ b/src/admin/AdminPhotosClient.tsx
@@ -80,7 +80,7 @@ export default function AdminPhotosClient({
                 )}
                 spinnerColor="text"
                 spinnerClassName="text-blue-200 dark:text-blue-600/40"
-                hideTextOnMobile={false}
+                hideText="never"
               >
                 <ResponsiveText shortText={photosCountNeedsSync}>
                   {pluralize(
diff --git a/src/admin/AdminPhotosSyncClient.tsx b/src/admin/AdminPhotosSyncClient.tsx
index 25f60287..5f37eb82 100644
--- a/src/admin/AdminPhotosSyncClient.tsx
+++ b/src/admin/AdminPhotosSyncClient.tsx
@@ -49,7 +49,7 @@ export default function AdminPhotosSyncClient({
       accessory={<ProgressButton
         primary
         icon={<IconGrSync className="translate-y-[1px]" />}
-        hideTextOnMobile={false}
+        hideText="never"
         progress={progress}
         tooltip={photos.length === 1
           ? 'Sync data for 1 photo'
diff --git a/src/admin/AdminUploadsTableRow.tsx b/src/admin/AdminUploadsTableRow.tsx
index 18e666c7..9ec13ae3 100644
--- a/src/admin/AdminUploadsTableRow.tsx
+++ b/src/admin/AdminUploadsTableRow.tsx
@@ -115,13 +115,13 @@ export default function AdminUploadsTableRow({
                   <AddButton
                     path={pathForAdminUploadUrl(url)}
                     disabled={isDeleting}
-                    hideTextOnMobile={false}
                     tooltip="Add directly"
+                    hideText="never"
                   />
                   <EditButton
                     path={pathForAdminUploadUrl(url)}
                     tooltip="Review photo details"
-                    hideText
+                    hideText="always"
                   />
                   <DeleteBlobButton
                     urls={[url]}
diff --git a/src/admin/ClearCacheButton.tsx b/src/admin/ClearCacheButton.tsx
index 8959fb46..a033e6c4 100644
--- a/src/admin/ClearCacheButton.tsx
+++ b/src/admin/ClearCacheButton.tsx
@@ -12,7 +12,7 @@ export default function ClearCacheButton() {
     <form action={clearCacheAction}>
       <SubmitButtonWithStatus
         icon={<BiTrash size={16} />}
-        hideTextOnMobile={false}
+        hideText="never"
         onFormSubmit={invalidateSwr}
       >
         Clear Cache
diff --git a/src/admin/EditButton.tsx b/src/admin/EditButton.tsx
index 6074a1e3..cc51e191 100644
--- a/src/admin/EditButton.tsx
+++ b/src/admin/EditButton.tsx
@@ -5,9 +5,7 @@ import { ComponentProps } from 'react';
 export default function EditButton ({
   children,
   ...props
-}: {
-  hideText?: boolean
-} & ComponentProps<typeof PathLoaderButton>) {
+}: ComponentProps<typeof PathLoaderButton>) {
   return (
     <PathLoaderButton
       {...props}
diff --git a/src/components/ImageInput.tsx b/src/components/ImageInput.tsx
index d9f1437e..158a1438 100644
--- a/src/components/ImageInput.tsx
+++ b/src/components/ImageInput.tsx
@@ -82,7 +82,7 @@ export default function ImageInput({
               />}
               aria-disabled={disabled}
               onClick={() => inputRef.current?.click()}
-              hideTextOnMobile={false}
+              hideText="never"
               primary
             >
               {isUploading
diff --git a/src/components/more/MoreMenuItem.tsx b/src/components/more/MoreMenuItem.tsx
index 093e3fb6..2a98b124 100644
--- a/src/components/more/MoreMenuItem.tsx
+++ b/src/components/more/MoreMenuItem.tsx
@@ -134,7 +134,7 @@ export default function MoreMenuItem({
       <LoaderButton
         icon={icon}
         isLoading={isLoading || isPending}
-        hideTextOnMobile={false}
+        hideText="never"
         styleAs="link-without-hover"
         className="translate-y-[0.5px] text-sm grow"
         classNameIcon="translate-y-[-0.5px]!"
diff --git a/src/components/primitives/LoaderButton.tsx b/src/components/primitives/LoaderButton.tsx
index c4b69f14..c2167c9c 100644
--- a/src/components/primitives/LoaderButton.tsx
+++ b/src/components/primitives/LoaderButton.tsx
@@ -19,7 +19,7 @@ export default function LoaderButton({
   spinnerColor,
   spinnerClassName,
   styleAs = 'button',
-  hideTextOnMobile = true,
+  hideText = 'on-mobile',
   confirmText,
   shouldPreventDefault,
   primary,
@@ -39,7 +39,7 @@ export default function LoaderButton({
   spinnerColor?: SpinnerColor
   spinnerClassName?: string
   styleAs?: 'button' | 'link' | 'link-without-hover'
-  hideTextOnMobile?: boolean
+  hideText?: 'always' | 'on-mobile' | 'never'
   confirmText?: string
   shouldPreventDefault?: boolean
   primary?: boolean
@@ -96,7 +96,8 @@ export default function LoaderButton({
         </span>}
       {children && <span className={clsx(
         styleAs !== 'button' && isLoading && 'text-dim',
-        hideTextOnMobile && icon !== undefined && 'max-sm:hidden',
+        hideText === 'on-mobile' && icon !== undefined && 'max-sm:hidden',
+        hideText === 'always' && 'hidden',
       )}>
         {children}
       </span>}